mdr-operator: add MDRT negative validation test (RHWA-1249) - #88

🌐 Web query:

For k8s.io/apimachinery v0.35.2, does pkg/api/errors.IsInvalid classify Kubernetes API responses with reason Invalid?

💡 Result:

Yes, for k8s.io/apimachinery v0.35.2, the function pkg/api/errors.IsInvalid classifies Kubernetes API responses with the reason Invalid [1][2]. The IsInvalid function determines if an error indicates a resource is invalid by checking two conditions [1]: 1. It checks if the error's reason is equal to metav1.StatusReasonInvalid (which corresponds to the string "Invalid") [1]. 2. It also returns true if the error's HTTP status code is http.StatusUnprocessableEntity (422) and the reason is not a known reason, ensuring broader compatibility with API responses that may not explicitly include the "Invalid" reason string [1][2]. This dual-check approach allows the function to identify "Invalid" errors even in scenarios where the explicit reason field might be missing or different, provided the HTTP status code correctly identifies the response as an unprocessable entity [1][2].

Citations:

• 1: https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go
• 2: kubectl: non-helpful error for 422 webhook status with no Reason field kubernetes/kubernetes#111108

🏁 Script executed:

#!/bin/bash
set -eu

printf '%s\n' '--- target file ---'
sed -n '1,150p' tests/mdr-operator/tests/mdr_negative.go

printf '%s\n' '--- reporter usages ---'
rg -n -C 3 'ReportIfFailed|ReportAfterEach|ReportBeforeEach' tests --glob '*.go'

printf '%s\n' '--- Kubernetes dependency ---'
rg -n 'k8s.io/apimachinery' go.mod go.sum

Repository: medik8s/system-tests

Length of output: 8747

🏁 Script executed:

#!/bin/bash
set -eu

printf '%s\n' '--- MDR test names ---'
rg -n -C 3 'MDRTInvalidTestName|MDRTNegativeTestName' tests/mdr-operator

printf '%s\n' '--- suite reporter setup ---'
sed -n '1,60p' tests/mdr-operator/mdr_suite_test.go

printf '%s\n' '--- local Kubernetes source/cache candidates ---'
find . -path '*apimachinery*errors.go' -o -path '*api/errors*' | head -20

Repository: medik8s/system-tests

Length of output: 7252

🌐 Web query:

k8s.io/apimachinery v0.35.2 pkg/api/errors IsInvalid StatusError Details Causes source

💡 Result:

In the k8s.io/apimachinery library (version v0.35.2), the StatusError type, its validation methods, and the associated error details are located in the pkg/api/errors package [1][2]. StatusError Structure The StatusError type is defined as a struct that wraps a metav1.Status object [3][4]: type StatusError struct { ErrStatus metav1.Status } APIStatus Interface The package provides an APIStatus interface, which is implemented by StatusError to allow access to the underlying metav1.Status [3][4]: type APIStatus interface { Status metav1.Status } Validation and Details The IsInvalid function determines if an error indicates that a resource is invalid by checking if the StatusReason matches metav1.StatusReasonInvalid [1][5]. The Details field within the Status object is of type *metav1.StatusDetails, which contains a Causes field [1][6]. The Causes field is a slice of metav1.StatusCause objects, each containing: - Type: The type of the cause (e.g., CauseTypeFieldValueInvalid, CauseTypeFieldValueRequired) [7]. - Message: A human-readable description of the error [1]. - Field: The specific field path that caused the error [1][7]. Creation The NewInvalid function is commonly used to create these errors. It accepts a qualified kind, a name, and a list of field errors (field.ErrorList), transforming them into the StatusDetails structure with the appropriate Causes [1][5]: func NewInvalid(qualifiedKind schema.GroupKind, name string, errs field.ErrorList) *StatusError Source Code The source code for this package is managed within the main Kubernetes repository under the staging/src/k8s.io/apimachinery directory and is synced to the standalone k8s.io/apimachinery repository [8][2]. You can inspect the implementation in the pkg/api/errors/errors.go file within that repository [1].

Citations:

• 1: https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go
• 2: https://pkg.go.dev/k8s.io/apimachinery@v0.35.2
• 3: https://github.com/kubernetes/kubernetes/blob/v1.21.0/staging/src/k8s.io/apimachinery/pkg/api/errors/errors.go
• 4: https://github.com/kubernetes/kubernetes/blob/63b36867/staging/src/k8s.io/apimachinery/pkg/api/errors/errors.go
• 5: https://gitcode.com/openeuler/oncn-bwm/blob/master/multi_prio_bwm/vendor/k8s.io/apimachinery/pkg/api/errors/errors.go
• 6: https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/status/
• 7: https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors_test.go
• 8: https://pkg.go.dev/k8s.io/apimachinery/pkg/api/errors

🏁 Script executed:

#!/bin/bash
set -eu

python3 - <<'PY'
import re
import urllib.request

url = "https://raw.githubusercontent.com/kubernetes/apimachinery/v0.35.2/pkg/api/errors/errors.go"
source = urllib.request.urlopen(url, timeout=10).read().decode()

is_invalid = re.search(
    r'func IsInvalid\(err error\) bool \{(?P<body>.*?)\n\}',
    source,
    re.S,
)
new_invalid = re.search(
    r'func NewInvalid\(.*?\) \*StatusError \{(?P<body>.*?)\n\}',
    source,
    re.S,
)

print("IsInvalid implementation:")
print(is_invalid.group(0) if is_invalid else "not found")
print("\nNewInvalid implementation:")
print(new_invalid.group(0) if new_invalid else "not found")
print("\nStatus-cause references:")
for line in source.splitlines():
    if "Cause" in line or "Field" in line:
        print(line)
PY

Repository: medik8s/system-tests

Length of output: 2444

🏁 Script executed:

#!/bin/bash
set -eu

tmp="$(mktemp)"
trap 'rm -f "$tmp"' EXIT
curl -fsSkL --connect-timeout 10 \
  https://raw.githubusercontent.com/kubernetes/apimachinery/v0.35.2/pkg/api/errors/errors.go \
  -o "$tmp"

python3 - "$tmp" <<'PY'
import re
import sys

source = open(sys.argv[1], encoding="utf-8").read()

for name in ("IsInvalid", "NewInvalid"):
    match = re.search(rf"func {name}\b.*?(?=\nfunc |\Z)", source, re.S)
    print(f"{name}:")
    print(match.group(0) if match else "not found")

print("Status-cause references:")
for line in source.splitlines():
    if "Cause" in line or "Field" in line:
        print(line)
PY

Repository: medik8s/system-tests

Length of output: 2799